v4-core
v4-core copied to clipboard
⚡ Save sload in Owned.sol
Since setOwner()
is onlyOwner
restricted, and there is already a check that msg.sender
is owner
, we can just pass msg.sender
into change event rather than loading owner again.
Please can you run yarn snapshots
and push the resultant gas snapshots
Please can you run
yarn snapshots
and push the resultant gas snapshots
Just ran. Not sure how to capture forge snapshot difference in this codebase.
Just ran. Not sure how to capture forge snapshot difference in this codebase.
We can't yet sadly - we had some issues with CI so had to remove it temporarily. Hoping to bring it back soon
Looks great! Feel free to merge when youre ready :)
great @hensha256 I think we're gtg but looks like might need approval bump cuz ocd merged main branch into mine 😅
Hey @z0r0z ! Really sorry I didnt notice this earlier - we require commits to be signed on this repo for security reasons. Please can you sign your commits 🙏
Its your snapshots commit thats not signed
Hi! Still waiting on:
- Signing your old commit that wasnt signed - this will mean pushing new commits to the branch
-
yarn snapshots
needs to be run again - when you merged in main they became outdated
Hey happy to merge these changes. Can you update the branch?
replacing with https://github.com/Uniswap/v4-core/pull/440