v4-core icon indicating copy to clipboard operation
v4-core copied to clipboard

⚡ Save sload in Owned.sol

Open z0r0z opened this issue 1 year ago • 8 comments

Since setOwner() is onlyOwner restricted, and there is already a check that msg.sender is owner, we can just pass msg.sender into change event rather than loading owner again.

z0r0z avatar Jun 13 '23 22:06 z0r0z

Please can you run yarn snapshots and push the resultant gas snapshots

hensha256 avatar Jun 14 '23 11:06 hensha256

Please can you run yarn snapshots and push the resultant gas snapshots

Just ran. Not sure how to capture forge snapshot difference in this codebase.

z0r0z avatar Jun 14 '23 23:06 z0r0z

Just ran. Not sure how to capture forge snapshot difference in this codebase.

We can't yet sadly - we had some issues with CI so had to remove it temporarily. Hoping to bring it back soon

hensha256 avatar Jun 15 '23 08:06 hensha256

Looks great! Feel free to merge when youre ready :)

hensha256 avatar Jun 15 '23 08:06 hensha256

great @hensha256 I think we're gtg but looks like might need approval bump cuz ocd merged main branch into mine 😅

z0r0z avatar Jun 15 '23 15:06 z0r0z

Hey @z0r0z ! Really sorry I didnt notice this earlier - we require commits to be signed on this repo for security reasons. Please can you sign your commits 🙏

hensha256 avatar Jun 15 '23 15:06 hensha256

Its your snapshots commit thats not signed

hensha256 avatar Jun 15 '23 15:06 hensha256

Hi! Still waiting on:

  • Signing your old commit that wasnt signed - this will mean pushing new commits to the branch
  • yarn snapshots needs to be run again - when you merged in main they became outdated

hensha256 avatar Jun 20 '23 14:06 hensha256

Hey happy to merge these changes. Can you update the branch?

snreynolds avatar Dec 06 '23 19:12 snreynolds

replacing with https://github.com/Uniswap/v4-core/pull/440

marktoda avatar Dec 08 '23 22:12 marktoda