Mark Erikson

Results 1264 comments of Mark Erikson

@mweststrate Been trying to look into this further, and I think there's actually a flaw in my benchmarks. The benchmark repo currently uses a Node ESM script that directly imports...

@mweststrate saw you just merged a bunch of outstanding PRs. Just wanted to check back - do you think you'll have time to look at this in the near future?...

For those watching this issue: I spent the last couple days working to update my benchmarking setup, and then using Claude to help me analyze the performance of the various...

Sure, thanks for the update! Also happy to find time to talk directly about the benchmarking setup, the perf tweaks so far, and what you had in mind for a...

My last couple days worth of Immer work sessions have been focused on trying to rewrite the "finalization" logic. Currently, Immer relies on a full nested tree traversal. For every...

I think I have some good news: - got all the baseline tests passing - almost all the failing tests in the rest of the files are due to the...

I've continued going down the rabbit hole on this, and I now feel very confident this is going to be a significant overall improvement in perf! First, I've gotten the...

@mweststrate yeah, locally I saw that the prod artifact went from 11K to 17K (including both the finalization changes and the array methods), but that was with a bunch of...

I'm _very_ happy to report that I spent a ton of time working on reimplementing Immer's patch system to work with the callback notification logic... and that as of today...

The non-mutating array methods (`filter`, `find`, `map`, etc) all incur overhead due to the same creation of proxies for every value during iteration. I'm going to try doing a similar...