Mark Erikson
Mark Erikson
> Though maybe even in that case for simplicity and future-proofing it's better to just recommend memoization? That's actually exactly what this section of the doc is trying to warn...
Yeah, I think those are reasonable guidelines to have in here. (I still don't think "a bunch of additions" _actually_ qualifies as "expensive" per se, but I get your overall...
Not directly, no. RTK Query is very based on the idea of passing in cache key arguments for the logic to know _which_ cache entry you're dealing with. Can you...
@aryaemami59 note that the `ReactOriginal` changes were intentional - ESBuild still doesn't support deduplicating imports across multiple files, so prior to me consolidating all our React imports, we ended up...
yeah, the `default` thing was basically a hacky version of the `defaultInterop(someModule)` pattern that these bundling tools spit out :)
`alternate-renderers` existed because we've imported `unstable_batchedUpdates` from ReactDOM and React Native. But, alternate reconciler implementations like React-Three-Fiber and Ink might not export that and we didn't know to import from...
I honestly don't even remember why we had that there :)
This one will be trickier to review than the other repos, so I'll come back to this when I have more time to look at it.
Okay, dug through the code changes and the build output, and this seems reasonable. We'll go with it!
Sequence of fields inspected in `package.json` in order to locate a suitable bundle for use, and also what forms of JS artifacts are acceptable for each field. Specific example: -...