Mark Erikson

Results 1264 comments of Mark Erikson

I do see one issue with the example itself. Yes, all the input functions for `computationSelector` will get called with all the arguments, because that selector itself is getting called...

You mentioned that the patch resulted in "a great speedup". If you record a CPU profile, where is the extra time being spent? Is it just in comparisons? Is that...

@kyle-sawatsky if updating the base URL is the only concern, then the best approach is to initialize the API with a custom base query that reads the URL from the...

I see that you have set up a `useAppDispatch` hook per our recommendations. What is the TS-inferred type of `dispatch` at that point? Also, what does your store configuration look...

Sorry, to clarify, what is the type of the `dispatch` function variable, and the `AppDispatch` type? Are they the same inferred type? Does the inferred type include a mention of...

Yeah, the API slice TS types only know about the endpoints in the original definition. `someApi.injectEndpoints()` then returns the _same_ runtime object but with the additional TS types applied. That...

Not sure there's anything else we can do here without a repro.

Closing due to lack of repro.

@Rufai-Ahmed I'm not immediately sure if there's a way for us to detect that a given middleware has been added twice. Beyond that, this should be a pretty rare error....

Went ahead and added a new dev-mode check to `configureStore` that will look for duplicate middleware references and throw an error. That'll be out in 2.7.0 in the near future.