Mark Erikson

Results 1264 comments of Mark Erikson

`useQuery` does actually use `dispatch` internally to retrieve some info on subscription status, separate from actually dispatching actions. However, that perf chart seems abnormally complicated. Can you show your store...

@yeefun : yeah, to echo Lenz, having 21 middleware added to your store is _not_ good for perf. Middleware form a function call pipeline that wraps `dispatch`. If I have...

Also, something about that perf trace JSON file seems possibly corrupted or cut off - Chrome DevTools doesn't want to load it properly. I _may_ have gotten it to load...

@yeefun Gotcha, thanks. I looked at the minified app bundle that was linked from the perf trace, and I think I see at least 10 different instances of the listener...

@yeefun Another small thing I just noticed. This: ```ts matcher: (action) => isAnyOf( updateXxxData, updateYyyData, )(action), ``` should be rewritten as: ```ts matcher: isAnyOf( updateXxxData, updateYyyData, ) ``` Tiny thing,...

Closing as it seems like this is primarily an app configuration issue. If there's still further perf issues beyond too many API middleware, happy to discuss details!

This is probably the same issue as #1912 and #2086 - it's a limitation of `useSyncExternalStore`.

From some internal discussion: > If we ever had suspense hooks, that could be a serious blockers for correct types for those, just to bring that up > > ```ts...

Unfortunately it's not something I'm going to have time to look at any time soon. My current focus is wrapping up the Immer perf work, and then I'll be turning...

@remkodejong there's been no discussion from anyone or comments from us, so no :) As always, PRs would be welcome!