Dr Mark C. Sinclair
Dr Mark C. Sinclair
I think the tests for u16chr and u16tok (both variants) are complete, so the next task is to identify and correct any additional incorrect uses of u16chr, where second parameter...
Ready for review, although waiting for PR #11910 to be merged into master first.
[PR #11910](https://github.com/keymanapp/keyman/pull/11910) has been merged into master, and in turn into this PR, so it is ready to be reviewed. Compared to [PR #11910](https://github.com/keymanapp/keyman/pull/11910), this PR offers more extensive testing...
> Noting that the title and description suggest changes to the compiler code, not just the tests -- is there something missing? This PR originally contained a fix to the...
Hmm ... not sure if I should have approved this in draft, but I thought it was ready to go.
Hmm ... merging master seems to have been a mistake *sigh*
Hmm ... one of the commits ([54d82b5](https://github.com/keymanapp/keyman/pull/11663/commits/54d82b505207e0bf38c9aaec0ab97373d5e34d88)) says `initFileKeyboard` when it should say `deleteFileKeyboard` ... too late to change.
Putting this in for review as it stands, and will continue in a new PR. There are several test cases written but commented out due to issues [#11814](https://github.com/keymanapp/keyman/issues/11814) (`u16tok()` bug)and...
> LGTM outside of lines 876 - 879. > > I'm not currently able to adequately parse the setup for that block to know why the test works and makes...
Re-review requested as nine test cases uncommented and passing due to having merged #11938 and #11910 into master.