Dr Mark C. Sinclair

Results 44 comments of Dr Mark C. Sinclair

> > It would be good to have an SIL boilerplate header on all source files ([@mcdurdin](https://github.com/mcdurdin) says not stricktly necessary): > > As in, for existing code we add...

> If possible, could we add Javadoc comments to some additional functions/classes, such as: > > * [`getTrueIndex()`](https://github.com/keymanapp/keyman/blob/69d162696a2175b6805e68bae31bf9dddfc267ce/web/src/engine/predictive-text/worker-thread/src/main/correction/classical-calculation.ts#L309-L321) > * [`getCostAt()`](https://github.com/keymanapp/keyman/blob/69d162696a2175b6805e68bae31bf9dddfc267ce/web/src/engine/predictive-text/worker-thread/src/main/correction/classical-calculation.ts#L323-L337) > * [`initialCostAt()`](https://github.com/keymanapp/keyman/blob/69d162696a2175b6805e68bae31bf9dddfc267ce/web/src/engine/predictive-text/worker-thread/src/main/correction/classical-calculation.ts#L505-L524) > * [`getSubset()`](https://github.com/keymanapp/keyman/blob/69d162696a2175b6805e68bae31bf9dddfc267ce/web/src/engine/predictive-text/worker-thread/src/main/correction/classical-calculation.ts#L526C3-L559) > * [`addInputChar()`](https://github.com/keymanapp/keyman/blob/69d162696a2175b6805e68bae31bf9dddfc267ce/web/src/engine/predictive-text/worker-thread/src/main/correction/classical-calculation.ts#L561-L566)...

> Are these getters ever used? > > * [`mapKey()`](https://github.com/keymanapp/keyman/blob/69d162696a2175b6805e68bae31bf9dddfc267ce/web/src/engine/predictive-text/worker-thread/src/main/correction/classical-calculation.ts#L775-L779) > * [`lastInputEntry()`](https://github.com/keymanapp/keyman/blob/69d162696a2175b6805e68bae31bf9dddfc267ce/web/src/engine/predictive-text/worker-thread/src/main/correction/classical-calculation.ts#L781-L783) > * [`lastMatchEntry()`](https://github.com/keymanapp/keyman/blob/69d162696a2175b6805e68bae31bf9dddfc267ce/web/src/engine/predictive-text/worker-thread/src/main/correction/classical-calculation.ts#L785-L787) Address in PR [#15296](https://github.com/keymanapp/keyman/pull/15296)

> > Can you give some extra explanation for [`validate the match`](https://github.com/keymanapp/keyman/blob/69d162696a2175b6805e68bae31bf9dddfc267ce/web/src/engine/predictive-text/worker-thread/src/main/correction/classical-calculation.ts#L973-L980)? Is this just the check on line 974, or the `input == match` on 978? > > Line...