Dr Mark C. Sinclair

Results 44 comments of Dr Mark C. Sinclair

> I'm admittedly not terribly clear on the cases from among the newly-uncommented nine (see [ea0a2f7](https://github.com/keymanapp/keyman/commit/ea0a2f780e31318503c635245215077d5aa12485)) that involve the special Keyman-language keyword `beep` in the midst of other statements, but...

It would appear the compiler does not require spaces between the modifiers, or between the modifiers and the key portion, so `[CTRLK_A]` compiles as if `[CTRL K_A]`, `[CTRLALT K_A]` as...

In addition, there is a space problem with grouping multiple virtual keys. The compiler sees `[K_A K_B K_C]` as `K_A` followed by `K_` followed by `K_`.

Hmm ... merging master seems to have been a mistake sigh

Ready for review. Errors/warnings will be added later. I will write up some notes on the lexer in [Next Generation KMN Compiler](https://docs.google.com/document/d/19MqA2rhTX5ibY8NuYqviKfH-R39-MIRisTRWRGaOoFE/edit?tab=t.0#heading=h.m0tbta4qzj0r) shortly.

Added doc hyperlink for most TokenTypes (omitting e.g. COMMA)

Okay, I think that's all the review comments addressed - it was a bit hard to track due to the outdated code/refactor/filename change effects.

I merged #11910 into #11894, so I'm waiting for #11910 to be merged into master before I submit #11894 for review. Josh has approved #11910, so I'm hoping you will...

I am currently writing a replacement for the `kmc-kmn` compiler, called the next generatioin compiler or just `ng-compiler` (see [#13553](https://github.com/keymanapp/keyman/pull/13553)). It is not yet integrated with the `kmc` tooling, but...

Ready to review. Some tidying up, with additional initialiser funtions, of `gtest-compiler-test.cpp`. Most new test cases address `use()`, `reset()` and virtual keys. There are some problems with spacing of virtual...