mark9064

Results 285 comments of mark9064

Yeah more broadly there is #1592 The disc could be resized, it's a small PNG that's been converted to LVGL format. The original PNG is in the tree (icons/music/disc.png)

Thanks for the patch :) This should have already been resolved by #2329 as this now enforces 100 ticks between each `UpdateMotion` call, could you try InfiniSim with the latest...

I think there's a deeper question: what are the InfiniTime temperature colours, is there a continuous scale, and when discrete steps are needed what temperature does it change at The...

Yeah you should be able to run `clang-format` (optionally with `-i` for inplace) from the repository root and give it the path to any file IIRC You will need to...

Oh, and you might also want to enable the pre-commit hook that automatically runs clang-format when you commit

PR for InfiniSim is the way. It doesn't block review of the code here, so no rush in making it

I like the work here. I'm finding it quite hard to review though because we haven't actually figured out what this data is for yet right? I think we would...

Oh, this needs GCC 14 as well

GCC 14 here #2372, not going to rebase on to it as I don't think that will fix CI

Yeah this is ready, I've been working on this for >2 years so I'm pretty happy with everything here (of course there's gonna be review feedback etc. but the design...