Marius van Niekerk

Results 112 comments of Marius van Niekerk

Might be worth using https://github.com/jheddings/notional for this once that has reached sufficient maturity

I'd recommend we vend in the current state of that file and pull it on demand

And I guess read from some RC file

I've started seeing this on my builds now too. Anything potentially useful to diagnose this behavior?

Tailing the logs of buildkit I see something like ``` time="2021-12-13T14:50:53Z" level=info msg="response completed" go.version=go1.17.3 http.request.host="127.0.0.1:8371" http.request.id=7bfd83bb-c3b6-4938-9b50-41d345720006 http.request.method=GET http.request.remoteaddr="172.17.0.1:41320" http.request.uri=/v2/ http.request.useragent="docker/20.10.9 go/go1.16.8 git-commit/79ea9d3 kernel/4.14.248-189.473.amzn2.x86_64 os/linux arch/amd64 UpstreamClient(Docker-Client/20.10.9 \\(linux\\))" http.response.contenttype="application/json; charset=utf-8"...

```shell $ perf top -g ``` ``` + 73.95% 5.75% buildkitd [.] github.com/moby/buildkit/cache/remotecache/v1.(*normalizeState).checkLoops ▒ + 24.92% 0.08% perf [.] hist_entry_iter__add ▒ + 19.30% 19.28% buildkitd [.] runtime.mapiternext ▒ + 14.80%...

Might be related https://github.com/moby/buildkit/issues/2009

Additionally when cancelling the build, the buildkitd instance is still busy doing whatever it was stuck on.