Marissa Huysentruyt

Results 14 comments of Marissa Huysentruyt

After touching base with design, we do not need to reintroduce disabled status lights. > The [status light] guidelines page on the website is outdated--you are right, in S2 design...

recreated this work in: https://github.com/adobe/spectrum-css/pull/3628

> * Last thing - what is the minimised variant? I assume it's just like a search icon that you click on and then the search field appears? Do you...

@rise-erpelding thanks for all of this feedback! > The footer content disappears in fullscreen, is that expected? > is the close button allowed to be used for fullscreen mode >...

> With this finding, was the design team planning to update token values? Or update what is listed on the Figma specs redlines? @jawinn I have not asked design, that's...

TODO: take in the new takeover dialog tokens https://github.com/adobe/spectrum-tokens/releases/tag/%40adobe%2Fspectrum-tokens%4013.0.0-beta.50

A few additional cards came out of this work. We'll need to follow up with design a some questions when design reviews happen once again. - [CSS-1057](https://jira.corp.adobe.com/browse/CSS-1057) to address the...

@rise-erpelding thanks for taking a second look after the rebase. > "Default" vs. "Standard" I changed the story name back to "Default": https://github.com/adobe/spectrum-css/pull/2793/commits/4d0344385cf8194ec930852987bf8bd1360829f4 > There is an "Overbackground" variant on...

For posterity, the static white & static black stories are considered "advanced" settings for particular downstream use cases, but they are "not things we wanted to surface widely."

> I think we need to adjust the dependencies. It should load if buttongroup is added to `devDependencies`. Good catch- totally overlooked that. It's added to `devDependencies` now: https://github.com/adobe/spectrum-css/pull/2861/commits/ba0831bb0f650d8ad5549684ca4a6207893fd81e