spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

fix(statuslight): add disabled styles

Open marissahuysentruyt opened this issue 1 year ago • 3 comments

Description

where they were removed: https://github.com/adobe/spectrum-css/pull/1495 docs-to-storybook: https://github.com/adobe/spectrum-css/pull/3152

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • [ ] The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • [ ] VRTs have been run and looked at.
  • [ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • [ ] I have read the contribution guidelines.
  • [ ] I have updated relevant storybook stories and templates.
  • [ ] I have tested these changes in Windows High Contrast mode.
  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [ ] ✨ This pull request is ready to merge. ✨

marissahuysentruyt avatar Sep 23 '24 18:09 marissahuysentruyt

⚠️ No Changeset found

Latest commit: bd5163466e942eb3ca3ee8a9b19e5b705126b664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 23 '24 18:09 changeset-bot[bot]

File metrics

Summary

Total size: 4.31 MB* Total change (Δ): ⬆ 1.37 KB (0.03%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
statuslight 11.83 KB ⬆ 0.47 KB

Details

statuslight

File Head Base Δ
index-base.css 11.83 KB 11.38 KB ⬆ 0.47 KB (4.01%)
index-vars.css 11.83 KB 11.38 KB ⬆ 0.47 KB (4.01%)
index.css 11.83 KB 11.38 KB ⬆ 0.47 KB (4.01%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

github-actions[bot] avatar Sep 23 '24 19:09 github-actions[bot]

🚀 Deployed on https://pr-3153--spectrum-css.netlify.app

github-actions[bot] avatar Sep 23 '24 19:09 github-actions[bot]

After touching base with design, we do not need to reintroduce disabled status lights.

The [status light] guidelines page on the website is outdated--you are right, in S2 design we do not have the disabled state for status light (not in Figma or in S2 token specs). I do not think we should be supporting it any longer in CSS In terms of updating the website to reflect newer changes like this, we have a longer roadmap to address all new changes.

Until we have the roadmap and strategy in place we’ll need to manage these changes in the old documentation reactively, if at all, I think.

marissahuysentruyt avatar Oct 30 '24 15:10 marissahuysentruyt