spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

feat(helptext): s2 migration

Open mdt2 opened this issue 1 year ago • 3 comments

Description

This is blocked by S2 icons.

S2 migration for help text which includes font, color, spacing, and icon changes.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • [ ] The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • [ ] VRTs have been run and looked at.
  • [ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • [ ] I have read the contribution guidelines.
  • [ ] I have updated relevant storybook stories and templates.
  • [ ] I have tested these changes in Windows High Contrast mode.
  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [ ] ✨ This pull request is ready to merge. ✨

mdt2 avatar May 01 '24 22:05 mdt2

🦋 Changeset detected

Latest commit: c6a6f6016858460e17cdea0c152e400da5802983

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@spectrum-css/helptext Major
@spectrum-css/fieldgroup Major
@spectrum-css/picker Major
@spectrum-css/textfield Major
@spectrum-css/tabs Major
@spectrum-css/combobox Major
@spectrum-css/datepicker Major
@spectrum-css/pagination Major
@spectrum-css/search Major
@spectrum-css/stepper Major
@spectrum-css/slider Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 01 '24 22:05 changeset-bot[bot]

🚀 Deployed on https://pr-2723--spectrum-css.netlify.app

github-actions[bot] avatar May 02 '24 19:05 github-actions[bot]

File metrics

Summary

Total size: 4.33 MB* Total change (Δ): ⬆ 0.07 KB (0.00%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
helptext 7.50 KB ⬇ 0.02 KB

Details

helptext

File Head Base Δ
index-base.css 7.50 KB 7.52 KB ⬇ 0.02 KB (-0.25%)
index-vars.css 7.50 KB 7.52 KB ⬇ 0.02 KB (-0.25%)
index.css 7.50 KB 7.52 KB ⬇ 0.02 KB (-0.25%)
metadata.json 3.68 KB 3.55 KB ⬆ 0.13 KB (3.63%)
* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

github-actions[bot] avatar May 02 '24 19:05 github-actions[bot]

recreated this work in: https://github.com/adobe/spectrum-css/pull/3628

marissahuysentruyt avatar Apr 01 '25 19:04 marissahuysentruyt

Closing as #3628 covers this work and has been merged

rise-erpelding avatar Apr 07 '25 15:04 rise-erpelding