marcustyphoon
marcustyphoon
I think I would start this discussion by going over what information we're trying to communicate with a PR's existence/last-updated time/draft state/review request state then picking a policy that facilitates...
Referencing the conversation we're having contemporaneously in another PR (for future reference: https://github.com/AprilSylph/XKit-Rewritten/pull/1997#discussion_r2549150599)... In that case, you to some extent correctly identified an action I could take, but was not...
Okay, I think I've got them: - Like the PR we are currently in, should PRs be draft-converted if (4) they have been agreed upon to be worth investigating, but...
> I think the biggest utility a draft PR has is as a signal to others that this particular thing is already being handled, and so there's no need for...
Yeah, I was hoping you might show a preference toward one of those options in particular :D But that may be getting ahead of ourselves; I haven't put a lot...
> A PR can double as an issue by describing the issue it resolves in its description, and I think that's fine as long as it doesn't delay acknowledgement of...
> I think I would start this discussion by going over what information we're trying to communicate with a PR's existence/last-updated time/draft state/review request state Having done so, back to...
Hm, apparently even without the a/b this code doesn't work right; the area to the left and right of the non-widened image is clickable. Not sure if I just messed...
Also, vimeo embeds are broken (too tall). Yes, I'm mostly just listing things for the eventual PR tests section.
Hm. - This note seems to appear (with slightly different, but not clearly different, copy... should probably put an mdn issue about that) in the equivalent `storage.onChanged` docs. If there...