AprilSylph
Panorama: Visual inconsistency in unexpanded media with new Tumblr A/B test
Platform
macOS 14.8.1 arm64
Browser
Firefox 145.0.1
Addon version
master
Details
Panorama seems to work pretty well with the current Tumblr a/b test with "Expand media content in wide posts" enabled, which is the default. However, with it disabled, media item borders are still wide.
Not sure if I should self assign this (sure doesn't seem like anyone else is going to do it) or help wanted it. I think this is much less important than #2001—that is probably a more popular feature, that is almost certainly a massively more popular non-default-enabled feature option, and the breakage there is a lot worse.
Not sure if I should self assign this (sure doesn't seem like anyone else is going to do it) or help wanted it.
The presence of an assignee should indicate intention. Let's not use too loose a definition of "intention", though...
How about we say that anything we don't expect to tackle in the next three months should not be assigned to us? It's long enough that it's forgiving, but not so long that it encourage us to allow issues in our assignment list to just become part of the UI.
Hm, apparently even without the a/b this code doesn't work right; the area to the left and right of the non-widened image is clickable. Not sure if I just messed this up in the original reimplement-panorama PR or if Tumblr's dom structure changed between when I wrote it and when it was merged. Oh well.
Also, vimeo embeds are broken (too tall).
Yes, I'm mostly just listing things for the eventual PR tests section.