marcustyphoon
marcustyphoon
Hmmmmnope, the Chrome audio player doesn't look like this.
Kind of works; should actually use a div around the chrome player so that if it ever loses its rounded corners only its background is rounded on the bottom edges,...
| master | unmodified pr | | - | - | | | |
Desktop Safari native audio player height, for reference: 31px. Screenshot without rounded corners: Design-wise, probably best if it floats a few pixels away, but the thing I did for Chrome...
Modifying the DOM structure to make the code more—that word that means "the same in different situations" that I forget... homomorphic? ```diff diff --git a/src/features/vanilla_audio/index.css b/src/features/vanilla_audio/index.css index bf6d8f1c..d120aaf3 100644 ---...
Options that I can think of that are... somewhat viable? - Just set `border-radius: 8px; margin-top: 2px;` or whatever on `${keyToCss('hasRoundedCorners')} > .${excludeClass} ~ audio[controls]` unconditionally - Make the default...
I guess in theory I could make this work on an element with two different images referenced in its background-image css value, but that sounds like a pain, we don't...
Note that this presumably would involve saving the user's remembered tabs in the utility (inheriting from Show Originals). Effectively this is moving a not-insignificant amount of Show Originals code into...
I think I'm missing something. Currently, without the A/B test, clicking the background of a post or reblog header opens the post permalink. We currently have a tweak which makes...
I'm still missing something! - Currently, with or without the A/B test, with or without our tweak, clicking the header background opens the post permalink. If we did a perfect...