marcustyphoon

Results 379 comments of marcustyphoon

todo: - ~~implement handling for changed blog names~~ - ~~rethink warning element insertion and state; current method is probably not viable even with refactoring~~ - ~~"when hiding **all** posts from...

> The blog name should be updated whenever the mute modal is opened for a muted blog - not when processing posts, despite the opportunity existing. (It is potentially problematic...

As of 26560e9, this currently uses a somewhat weird setup in which processPosts writes the blog UUIDs into post data attributes, and the logic for whether posts are hidden is...

Oh, interesting performance note: this won't use the `timelineObject` cache unless `timelineObject(noteElement)` is replaced by e.g. `timelineObject(noteElement.closest(postSelector))`, but that would require an exception to be made to work in the...

I assume this is about the new footer with user-specific buttons in a separate row above the current one and with note counts listed as e.g. "1.8k" instead of "1835."...

Hm, I guess in a perfect world we add a mute control button to the blog card menu, too.

> The warning in the blog view can hide the timeline using CSS that relies on the existence of the warning, e.g. .xkit-mute-warning + [data-timeline] { display: none; }, meaning...

That is... certainly... a term that describes it, I suppose, yes.

This appears to do fairly bad things to the foreground/background/postGlass setup in the cardPost element used in the recommended blog carousel, but I'm not sure why at the moment.