Marc T. Henry de Frahan

Results 150 comments of Marc T. Henry de Frahan

With some final tweaks, I think we are good to go. Running the GPU tests now.

I am seeing this: ``` The following tests FAILED: 7 - abl_godunov_mpl (Failed) 8 - abl_godunov_mpl_amr (Failed) 86 - rankine (Failed) 87 - rankine-sym (Failed) 90 - freestream_godunov_inout (Failed) 116...

I like splitting into diff and no-diff PR! That would be fantastic.

I am seeing this fail: ``` The following tests FAILED: 7 - abl_godunov_mpl (Failed) 8 - abl_godunov_mpl_amr (Failed) 85 - rankine (Failed) 86 - rankine-sym (Failed) ``` I think that's...

We have a DOI but it's not live yet. We can wait to merge this until it is live.

The DOI link is not updated yet but the url is live. Shall we merge @mbkuhn and @moprak-nrel ?

``` The following tests FAILED: 25 - abl_stable (Failed) no_ci regression -> O(1e-10) diffs 31 - abl_multiphase_laminar (Failed) no_ci regression -> machine diffs 32 - abl_waves_terrain (Failed) no_ci regression ->...

these are diffs between main and this PR

Ok I am seeing these fail: ``` The following tests FAILED: 25 - abl_stable (Failed) no_ci regression 31 - abl_multiphase_laminar (Failed) no_ci regression 32 - abl_waves_terrain (Failed) no_ci regression 33...