amr-wind icon indicating copy to clipboard operation
amr-wind copied to clipboard

Provide NPH data in physical boundaries to advection calculation

Open mbkuhn opened this issue 6 months ago • 4 comments

Summary

Changes requested in conjunction with AMReX-Hydro development. For the sake of time-varying boundary conditions, passing the advected variable data at n+1/2 to the advection routine.

Pull request type

Please check the type of change introduced:

  • [x] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

Checklist

The following is included:

  • [ ] new unit-test(s)
  • [ ] new regression test(s)
  • [ ] documentation for new capability

This PR was tested by running:

  • the unit tests
    • [ ] on GPU
    • [ ] on CPU
  • the regression tests
    • [ ] on GPU
    • [ ] on CPU

mbkuhn avatar Aug 21 '24 20:08 mbkuhn