Marc T. Henry de Frahan
Marc T. Henry de Frahan
Most of my comments right now are just noting the obvious things to clean up before actually merging. Thank you for taking this task on!!
I don't know that anyone is actively implementing this feature. Do you want to take a stab? Happy to discuss but I think you implemented the first part of this...
@moprak-nrel, @lawrenceccheung PR #1219 did something to address this issue. Should we close this one and maybe make a more specific issue for the part that was not addressed?
Hi @rthedin, If I am reading this right, there seems to be 2 issues going on? 1. statistics on fine levels 2. some discontinuity in the sampling For 1., this...
Ok I will have to think about this... For 2, @rthedin this feels like something in the ghost cells that's not initialized maybe. If you can provide an input fille,...
Hi, thanks for your questions. 1. This is concerning. Did the same exact input file for the neutral case work with your previous version of amr-wind? 2. Yes. Netcdf always...
Well the good news is that we didn't cause a regression... yeah you can reduce your dt until you find one that works for these velocities. Or you can have...
Hi @gyalla, do you think this is close to being able to merge? It looks like you addressed all the outstanding comments.
Oh if you still have things going on, feel free to keep it open. Re: the tests. I do have those working! But I need to move the pinned dev...
@gyalla got everything merged in! So those tests should pass now.