Marc T. Henry de Frahan
Marc T. Henry de Frahan
A meta comment here: to get past the CI check, the first thing you need to do is format your code. You can do that automatically with clang-format: https://exawind.github.io/amr-wind/developer/coding_guidelines.html#style-guide-recommendations
Can I do anything to help push this through? We are super close I think.
can you resolve those documentation conflicts?
@ayalamanuel I think we are close! I updated some things/fixed conflicts.
This runs fine on GPU.
Interesting issue... The proposed fix sounds kinda gnarly. Is there a way to talk to openfast devs to see if there's an easy way to automate this copying of arrays...
This is great except that it now all ranks need to know about the probe locations. So it ends up needing more memory in total though there is no spike....
Status update before I leave this aside for a bit: - there is currently are hard check that the number of particles added match what was expected to be added....
Progress is being made... I need to fix the m_fill_val in radar sampler to be the min of the domain (checking to see if that's allowed). And then netcdf builds...
We are close. I added the box check which is the thing that should help the memory pressure. I need to check it on a large case and see if...