Exawind
Adding a dynamic stress (wave model) to wall_models
Summary
we have introduced a dynamic stress as a wall model. the dynamic stress calculates the stress due to waves. a new struct was implemented in ShearStressSimple.H where the wave stress is calculated. a new header (MOSD.H) was created with the calculations of the stress. the WallFunction.cpp has been modified accordingly.
No unit testing or regression testing has been done.
Pull request type
Please check the type of change introduced:
- [ ] Bugfix
- [ x] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
Checklist
The following is included:
- [ ] new unit-test(s)
- [ ] new regression test(s)
- [ ] documentation for new capability
This PR was tested by running:
- the unit tests
- [ ] on GPU
- [ ] on CPU
- the regression tests
- [ ] on GPU
- [ ] on CPU
Additional background
Issue Number:
@marchdf Old files have been updated. Unit test, regression test and documentation have been added. Thanks!
A meta comment here: to get past the CI check, the first thing you need to do is format your code. You can do that automatically with clang-format: https://exawind.github.io/amr-wind/developer/coding_guidelines.html#style-guide-recommendations
@marchdf @moprak-nrel sorry for taking so long with this! Hopefully it's almost finished
seems like the documentation issues are because I used and outdated theory.rst file. How can I update that file in my branch? then I can just add the once again the new part of documentation from my implementation
seems like the documentation issues are because I used and outdated theory.rst file. How can I update that file in my branch? then I can just add the once again the new part of documentation from my implementation
I would rebase your branch with the latest amr-wind main and resolve any conflicts there. You'll need to do this before the PR is ready for merging anyway.
