Maximilian Antoni

Results 181 comments of Maximilian Antoni

Yes that would be nice and consistent with GitHub. It also gives us more freedom with naming future modules 👍

Issue for nise: https://github.com/sinonjs/nise/issues/77

Java has automatic tools to generate JavaDocs without manual work. To achieve something like this in a JS library requires a ton of manual work. I'd love to see something...

Hmmm, I like the idea (and made something similar myself before with https://github.com/mantoni/mocha-referee-sinon), but I'm wondering if it would be enough to simply document this approach on the website? It...

> // passes > spy.calledOnceWithExactly(spy.getCall(0), 5, 100) There are two things wrong with this: 1. The function never throws, it returns `true` or `false`, so it always "passes". 2. The...

Anyway, I think this is a copy-paste bug in the documentation. It makes not much sense to check that a single call was called once. If the call wasn't made...

Stack trace usefulness and discussions about whether one should create error objects aside, I agree that generally ```js const example = sinon.stub().rejects(something); ``` should behave the same as ```js const...

Related discussion in #1000.

I thought about it some more. I think it would make sense to bundle `sandbox`, `fake` and `lolex`. Everything can be done with those 3 cross platform. `nise` is a...

@fearphage `sandbox` is implicitly used all the time since `sinon` itself is a default sandbox. While `spy` and `stub` are the oldest parts of the API, the `fake`s where introduced...