Maximilian Antoni

Results 108 comments of Maximilian Antoni

Thank you for raising this. You're right that it's unnecessary and inefficient to encode the `text` in JSON. Since this would be a breaking change, I'd like to take a...

Option 2️⃣ is becoming my preference. I think of `core_d` as a convenience utility that allows me to safely start and stop a daemon process for something like `eslint_d`. It...

I see. My proposal is a solution that is a mix of both. I'd change the protocol to be: ``` ``` The first line is the current working directory, as...

I like where this collaborative idea development is going 👍 I'd like to keep the `cwd` an explicit part of the protocol because `eslint_d` sets it itself. I like the...

That makes sense. Would you care to send a PR to implement this?

Great! I think it should be called `ESLINT_D_MAX_INSTANCES` because the cache is implemented here. You can see examples for testing in `eslint-path-test`.

`npm link` worked fine for me when testing. But you can also simply invoke the `bin/eslint_d.js` file from anywhere.

Hmm, eslint_d creates a new instance if the current working directory changes. Maybe the `cwd` is not the project root when you pull out a file into a new window?...

I'm open to your suggestions. I wonder how eslint itself handles this. Ideally eslint_d behaves the same, or even uses eslint APIs to find the cwd. If that's possible, I...

Another idea: How about checking if the current cwd is a sub-directory of one of the cached instances?