Maximilian Antoni

Results 181 comments of Maximilian Antoni

You can launch `safaridriver` locally. It ships with Safari. Setup and config examples are documented here: https://github.com/mantoni/mochify.js/blob/rewrite/driver-webdriver/README.md

Maybe we should make a major release first, and then deprecate that major. This would cause the warning to be shown when someone installs the package freshly, but doesn't add...

Just a thought: We could also publish nise as `@sinonjs/xhr` and lolex could become `@sinonjs/clock`. Less sexy, but more obvious.

I'm actually working on a Mochify rewrite (https://github.com/mantoni/mochify.js has a `rewrite` branch), and the current state seems to work fine. I just don't have enough free time to get it...

@itayperry You could start by checking out this branch and see if you can run Safari tests for fake-timers with it: https://github.com/mantoni/mochify.js/pull/241

Thanks for looking into it. There is clearly not enough documentation yet. I managed to run tests by invoking the new Mochify CLI locally using a relative path. However, I...

@itayperry It tried all evening, and it works for Safari, but not for any other browser 🙈. Your help on the above PR and / or the Mochify rewrite would...

I figured it out for this project and have a fix in https://github.com/mantoni/mochify.js/pull/244 (spoiler: there's a very subtle bug in the geckodriver). I'm happy to provide assistance for anyone who...

Wow, thank you for sending a PR for this so quickly! 🥇 Yes, I agree that this is pretty hacky, but at least we can control exactly what is going...

I've looked around some more and found another test case for esm that runs on Node: https://github.com/sinonjs/sinon/blob/d2b4b726529f167d908747d2173b5491794ac718/test/es2015/module-support-assessment-test.es6 Both test cases are triggered using these npm scripts: ```json { "test-esm": "mocha...