Filipe Azevedo
Filipe Azevedo
Fixes: https://github.com/graphprotocol/graph-node/issues/3060 This change should add a timestamp for EVM chains, should work well for both RPC and firehose ingestors. The fact the query depends heavily on the format of...
Cleaning up a leftover Error that's now unused.
The current e2e tests are hard to understand and maintain. A new flow should ideally separate the cluster management and the test concerns, allowing for a user to either re-use...
With the addition of new probes it is now possible to add valid, yet unused labels. We need to find a way to provide some warning or even automatic cleanup...
project_service used to deal with the different labels as a just in time validator that supported the converter. Example: https://github.com/appvia/kev/blob/master/pkg/kev/converter/kubernetes/project_service.go#L55 Now this validation should be done at the moment when...
Kind of related to #kev-493 Currently validation is achieved by case sensitive matching and a conversion function https://github.com/appvia/kev/blob/5a1c05c568427024fb3ef76a9fc0a5d6bdd1e341/pkg/kev/config/extensions.go#L317 https://github.com/appvia/kev/blob/5a1c05c568427024fb3ef76a9fc0a5d6bdd1e341/pkg/kev/config/extensions.go#L169 Should be possible to use custom validation in order to avoid...
Restart policy is now split between 2 places: https://github.com/appvia/kev/blob/5a1c05c568427024fb3ef76a9fc0a5d6bdd1e341/pkg/kev/config/extensions.go#L187 https://github.com/appvia/kev/blob/5a1c05c568427024fb3ef76a9fc0a5d6bdd1e341/pkg/kev/converter/kubernetes/project_service.go#L408 and some really inconvenient assertions (IMO) https://github.com/appvia/kev/blob/5a1c05c568427024fb3ef76a9fc0a5d6bdd1e341/pkg/kev/converter/kubernetes/project_service_test.go#L1052 A better way in my view would be to ensure all the logic...
https://github.com/appvia/kev/blob/5a1c05c568427024fb3ef76a9fc0a5d6bdd1e341/pkg/kev/config/extensions.go#L26 Review the existing validation: Specifically but not limited to: 1. one of for relevant fields, like workload type 2. pattern for time.Duration fields 3. any newly moved fields.
go-playground/validator's error messages are good from a developer point of view but an error messages that says "K8SConfiguration.Workload.Type is not a one of value" is not really helpful to the...