malte0811

Clarify contract of LazyOptional w.r.t. throwing Suppliers

2

[Currently](https://github.com/MinecraftForge/MinecraftForge/blob/74f9ef838a53acb1e7d3d09622b604d96cf02221/src/main/java/net/minecraftforge/common/util/LazyOptional.java) the contract does not specify anything about whether the `NonNullSupplier` is allowed to throw exceptions or not. In my mental model of `LazyOptional` they should never do this, and...

[1.17/Java 16] DistExecutor::validateSafeReferent crashes in dev

4

**Minecraft Version:** 1.17.1 **Forge Version:** 37.0.33 **Logs:** https://gist.github.com/malte0811/497c75ee3eb8641a6758ea2864cae330 **Steps to Reproduce:** 1. Add this class to an MDK ```java package com.example.examplemod; import net.minecraft.client.Minecraft; import net.minecraft.world.level.Level; public class ClientOnlyClass { public...

**Minecraft Version:** 1.19 **Forge Version:** 41.0.17 (latest at the time of writing) **Logs:** [debug.log](https://gist.github.com/malte0811/1b87b90595f5124381acff5d0c667f95) **Steps to Reproduce:** 1. Download the MDK for 41.0.17. 2. Apply [this](https://gist.github.com/malte0811/094a42210d70090270dd703a265f4612) change (i.e. throw an...

Redstone wire does not connect to the bottom of modded blocks

1

Original issue: BluSunrize/ImmersiveEngineering#3181 This seems to be caused by some code in FMP that assumes vanilla's `canConnectRedstone` can't handle the bottom side properly. The current `canConnectRedstone` is added by a...

Mostly a reminder for myself: If a line is exactly 120 pixels long (i.e. the length of a manual line) and is followed by a linebreak (in the raw txt...

Mixin config loads MC classes too early, causing other Mixins to fail

1

https://github.com/TheRandomLabs/RandomPatches/blob/a2a9f19caab38f3f4078bf5acadcca7e300d4788/src/main/java/com/therandomlabs/randompatches/mixin/RPMixinConfig.java#L59-L62 That causes the main mod class and various other classes (including `Identifier`/`ResourceLocation` via autoconfig and the fabric `Event` class) to be loaded before all Mixin configs are loaded. In...

[This](https://github.com/way2muchnoise/JustEnoughResources/blob/c640e058c596eccca1c9aa86c4645ca8f814a75f/src/main/java/jeresources/compatibility/minecraft/MobCompat.java#L28) static field is assigned to the client world when the class is first loaded, but the reference is never updated. So it will be kept around when switching servers/rejoining,...

Other IE addons and the projector

1

1. Currently only the "partial" excavator multiblocks don't have projectors (see [here](https://github.com/Flaxbeard/ImmersivePetroleum/blob/669f66e990516b52e3bc388beb62ad07cd1a80c2/src/main/java/flaxbeard/immersivepetroleum/common/items/ItemProjector.java#L173)), but there is no way for addons to disable them for their multiblocks. A specific usecase would be...