ImmersiveEngineering icon indicating copy to clipboard operation
ImmersiveEngineering copied to clipboard

Reduce size of recipes in PacketBuffer's

Open malte0811 opened this issue 5 years ago • 5 comments

malte0811 avatar Oct 17 '20 18:10 malte0811

I understand that this is a quick fix to the recipes added by IE, but shouldn't issues with vanilla shaped recipes be handled in Forge instead?

BluSunrize avatar Oct 18 '20 15:10 BluSunrize

No, Forge servers need to be compatible with vanilla clients and vice versa. With this changed format that isn't (easily?) possible.

malte0811 avatar Oct 18 '20 15:10 malte0811

Ah! I was unaware/ignorant of the fact that Forge and Vanilla required compatability. That said, Compressed Recipes could still be a part of Forge's framework, much like ShapedOre and ShapelessOre recipes were in past iterations, no? I'm not looking to dismantle this PR, I'm all for reducing the packet size, I'm just thinking that it would be good to standardize this across the modded community!

BluSunrize avatar Oct 18 '20 15:10 BluSunrize

@malte0811 Are you still looking to have this implemented?

BluSunrize avatar Nov 04 '20 13:11 BluSunrize

Probably some parts of it, but not everything. Some things are optimized much better in RecipeBuffers than they can be here, but other things I can't really influence from outside IE. I'll remove the parts that I don't want any more when I have some time.

malte0811 avatar Nov 04 '20 14:11 malte0811