Matt Liberty

Results 1712 comments of Matt Liberty

@gadfort opinion on how this should be implemented?

unordered_set won't help as it will just hash on the pointer value. A comparison should be provided to any set of pointers that will iterated.

I got tired on this happening with odb objects and created https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/src/odb/include/odb/dbCompare.inc. Perhaps we can do something similar for the relevant sta classes.

The drt issue comes from not using the DONT_USE_CELLS list and instantiating a probe cell (sky130_fd_sc_hd__probe_p_8). The router should not error in this way but you should not use this...

Please retest the RCX issue with whatever yosys version you are using.

Async is too much of a headache and won't really solve the problem (you would have to enforce that you can't do anything timing or db modification related). Discussed and...

Getting sta to allow an cancel-in-progress option would be the best. I also think it will be hard to get such an enhancement. There are a number of such places...

Still in the queue. The child is stored in the db so there is no need for a similar option on read_db.

Using ``` % buildifier --version buildifier version: 8.2.1 buildifier scm revision: b1e23f1025b8556cc75eebb28ff7f40b8930d353 ```