OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

read_def -child does not load macro to correct offset

Open oharboe opened this issue 1 year ago • 2 comments

Describe the bug

./run-me-mock-array-asap7-base.sh

read-def-child-offset.tar.gz

OpenROAD v2.0-16449-gd4470e407 
Features included (+) or not (-): +Charts +GPU +GUI +Python
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
GUI_TIMING=1 reading timing, takes a little while for large designs...
read_spef ./results/asap7/mock-array/base/6_final.spef
Populating timing paths...
[INFO ODB-0135] Reading DEF file: results/asap7/mock-array_Element/base/6_final.def
[INFO ODB-0128] Design: Element
[INFO ODB-0138]     Created 528 pins.
[INFO ODB-0139]     Created 8194 components and 20353 component-terminals.
[INFO ODB-0140]     Created 2 special nets and 16388 connections.
[INFO ODB-0141]     Created 1842 nets and 3945 connections.
[INFO ODB-0142] Finished DEF file: results/asap7/mock-array_Element/base/6_final.def

image

Expected Behavior

Render at correct offset

Environment

OpenROAD v2.0-16449-gd4470e407

To Reproduce

See above

Relevant log output

No response

Screenshots

No response

Additional Context

No response

oharboe avatar Oct 14 '24 14:10 oharboe

@maliberty Two questions:

  1. Can you reproduce?
  2. Just trying to understand. I found it surprising that "read_db" does not have a -child option. Isn't .odb a binary representation of .def + .lef? If so, I would expect all read_def options to be available with "read_db". https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/src/odb/README.md

For the read_def -child feature it is a bit awkward that the .odb file can't be used.

A feature that is frequently asked for when I show OpenROAD is whether it is possible to double click on the macros to drill into them.

read_def -child would be part of meeting such a seemingly reasonable request.

oharboe avatar Oct 16 '24 07:10 oharboe

Still in the queue. The child is stored in the db so there is no need for a similar option on read_db.

maliberty avatar Oct 16 '24 17:10 maliberty