Maksim Sabianin comments

Results 28 comments of


                                            Maksim Sabianin

[DeviceSanitizer] Support detecting out-of-bounds error on DeviceGlobals

I am OK to let this PR go in order to unblock other teams. Currently, the new Pass has 0 test coverage. @zhaomaosu Are you ok to address this in...

`sycl::kernel_handler::get_specialization_constant` calls `__sycl_getComposite2020SpecConstantValue` on enumerated `value_type`

@victor-eds please, attach the code.

[SYCL] Make PropertySetRegistry being owning it's content

From test's failures it looks like we can't simply change the order of spec const's IDs in metadata.

[SYCL] Make PropertySetRegistry being owning it's content

Status update: Initially I made a change that removes the order of elements in PropertyRegistry. Later on I found out that the current SpecConsts pass rely on that property and...

[SYCL] Make PropertySetRegistry being owning it's content

@asudarsa Could you please review this when you have free time?

[SYCL] Make PropertySetRegistry being owning it's content

Hi @asudarsa PropertySetIO doesn't belong to llvm-project.

[SYCL][ESIMD] Disable bitreverse recognition for non-std width

I would propose to add LIT test that checks one of LLVM Transformation passes.

[ESIMD][NFC] Extract ESIMD handling from sycl-post-link to library.

Speaking of the testing, different parts are being tested by LIT tests by `sycl-post-link`. Linking is tested independently from sycl. Lowering is tested by LITs. The control flow of `handleESIMD`...

[ESIMD][NFC] Extract ESIMD handling from sycl-post-link to library.

@asudarsa CI issues are really not related to this PR, I can see similar issues in https://github.com/intel/llvm/pull/19022 . @intel/llvm-gatekeepers Can we merge this?

[ESIMD][NFC] Extract ESIMD handling from sycl-post-link to library.

@sarnex thanks for pointing out! @intel/llvm-gatekeepers Can we merge this please?