llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[ESIMD][NFC] Extract ESIMD handling from sycl-post-link to library.

Open maksimsab opened this issue 7 months ago • 2 comments

This change extracts handleESIMD from sycl-post-link to SYCLPostLink component for reuse in NewOffloading compilation flow in clang and for reuse in sycl-jit.

The body of handleESIMD function is refactored for better readability.

The documentation of lowerESIMDConstructs is fixed and the argument name is changed to more straightforward.

maksimsab avatar May 27 '25 16:05 maksimsab

Speaking of the testing, different parts are being tested by LIT tests by sycl-post-link. Linking is tested independently from sycl. Lowering is tested by LITs. The control flow of handleESIMD is difficult to test by unittests.

maksimsab avatar Jun 13 '25 15:06 maksimsab

Hi @maksimsab I had a look at the build fails. Not really clear what the issue is. Did you figure it out? Thanks

asudarsa avatar Jun 17 '25 21:06 asudarsa

@asudarsa CI issues are really not related to this PR, I can see similar issues in https://github.com/intel/llvm/pull/19022 .

@intel/llvm-gatekeepers Can we merge this?

maksimsab avatar Jun 30 '25 11:06 maksimsab

@asudarsa CI issues are really not related to this PR, I can see similar issues in #19022 .

@intel/llvm-gatekeepers Can we merge this?

Could you please create issues against these failures?

dm-vodopyanov avatar Jun 30 '25 11:06 dm-vodopyanov

@intel/llvm-gatekeepers please consider merging

github-actions[bot] avatar Sep 08 '25 16:09 github-actions[bot]

@maksimsab is this actually ready for merge?

sarnex avatar Sep 08 '25 16:09 sarnex

@intel/llvm-gatekeepers please consider merging

github-actions[bot] avatar Sep 11 '25 16:09 github-actions[bot]

@maksimsab x2 is this actually ready for merge?

sarnex avatar Sep 11 '25 16:09 sarnex

@sarnex thanks for pointing out!

@intel/llvm-gatekeepers Can we merge this please?

maksimsab avatar Sep 12 '25 10:09 maksimsab