Mitchell Skaggs

Results 135 comments of Mitchell Skaggs

> @magneticflux- : is that dimension-based height-offset active? I cannot tell from your code (it looks like it gets set to 0 everytime :?). That's correct; the dimension-based height offset...

I think the idea of distributing the worlds like this is good, but I have two issues: 1. We should avoid special cases as much as possible, i.e. apply the...

@Robijnvogel Here's what I found for older versions if you want to backport to 1.15 instead of rebasing to 1.18: - 1.15: Use `world.getDimension().getType().getRawId()`. On Fabric at least this picks...

@Robijnvogel I started a prototype of such a stable hash function that you can use here: https://github.com/magneticflux-/fabric-mumblelink-mod/commit/3866317c64f9b7f5b9b4f17e88cd51c0a717b993 I checked that the three vanilla worlds all result in different values mod...

I'm releasing a 1.18 version of my mod soon, so [my proposed world ID hash](https://github.com/magneticflux-/fabric-mumblelink-mod/blob/3866317c64f9b7f5b9b4f17e88cd51c0a717b993/src/main/kotlin/com/skaggsm/mumblelinkmod/client/Utils.kt#L21-L30) will become harder to change. I don't plan on backporting to any other versions unless...

@zsawyer This should probably be done in the update to 1.18 to avoid breaking compatibility. Special attention should be paid to https://github.com/zsawyer/MumbleLink/pull/35 to ensure the correct coordinate is offset.

Also to consider: centering the signs' text and preserving blank lines in the sign. For centering theoretically you could add ` ` as the joiner, but that's not HTML5 😞....

`easy-add` might be able to be removed, I just added it because it was how @itzg did it in https://github.com/itzg/docker-minecraft-server/blob/fb92a74084da3ebfcd41a1043566d5c0638e7365/Dockerfile#L29-L57. You could probably just download the `rcon-cli` binary and manually...

`rcon-cli` has a `--password` flag that I use. I don't expose the RCON port at all, so there's no real point in a secure password.

`easy-add` was about 15MB. I removed it and downloaded `rcon-cli` manually and it's only 3MB. @itzg Maybe you could run some kind of optimization step on the Golang binaries when...