Mitchell Skaggs

Results 135 comments of Mitchell Skaggs

@NealSavage > The issue has been identified Three people _claim_ the issue exists. Nobody has provided a minimal reproduction of the issue. If you want somebody to fix it, provide...

@NealSavage Enable the "Memory Tracing" option and post logs with warnings again. That option may lower performance, but it will indicate where the memory leaked from.

Whoops, it was removed from the UI. It's an option in `.minecraft/config/sodium-options.json`

@TheIrishStud @cassphodel Logs from the two of you with this option enabled would also be appreciated, so we know if it's the same issue.

It might be possible to "intern" or cache calls to `BooleanProperty.of` like `String.intern()` does, so separate calls to `BooleanProperty.of(x)` return the same object. That would guarantee the uniqueness of Properties...

> [Sandwichable](https://github.com/FoundationGames/Sandwichable/) also has a similar issue. > > https://paste.ee/p/HhwLq I just tested with #22 and it seems to fix it.

The point of a reference hash map (rather than an object hash map) is _not_ to use `.equals` since `==` is significantly faster (a single integer comparison rather than a...

It sounds like an issue that needs to be fixed on DashLoader's end. I recommend trying to inject earlier and trying to make it compatible with https://github.com/CaffeineMC/hydrogen-fabric/pull/22

I don't know of any implementations that _don't_ call equals on the new object, but this change doesn't seem to have any downsides and it's always good to be cautious,...

@malte0811 That's true, if a mod implements `Property` on its own, it won't be cached. That isn't a big issue though because that mod implementation typically won't be used by...