Magnus Ihse Bursie
Magnus Ihse Bursie
Thanks @shipilev! I incorporated your patch, but I made the shift-negative-value conditional on s390x.
/contributor add @shipilev
@kimbarrett I promised a list of warnings that were previously globally (within hotspot) disabled, but are not now. Here it is: ### gcc ``` address cast-function-type char-subscripts empty-body misleading-indentation sequence-point...
The following warnings are truly globally disabled (for all native code in the JDK): ### gcc ``` unused unused-parameter ``` ### clang ``` unused unused-parameter unknown-warning-option ``` ### visual studio...
@shipilev The code history will probably be more straightforward if your fix goes in first. There's no real hurry with this one.
@shipilev I had hoped this PR would trigger warning hunting in Hotspot, but I did not anticipate that it would happen even before it was pushed! ;-) Let me know...
@shipilev So you want me to integrate this first, and then you follow up with your fixes?
Yes, that is my intention. I've been away for almost two weeks, taking care of my kids and then getting ill myself. :-( I'm wading through my backlog, and intend...
@shipilev In a "tenth time's the charm" spirit, here's what I do think is actually a PR that can be integrated. (This one was really messy, both due to me...
/label -build