Matthew Neeley

Results 62 comments of Matthew Neeley

One problem with the name "nursery" is it only conveys that this is a place where new tasks can be spawned. But the really important thing about a trio nursery...

Here's a maybe off topic question though. Does there need to be a nursery object at all? Since the boundary provided by a nursery is the same as the async...

Thanks for raising this issue. For some things I think it makes more sense to test against the oldest supported version (e.g. want to make sure we don't require new...

You need to use an _instance_ of `PhysicalZTag`, rather than the class itself: ``` >>> import cirq >>> q = cirq.LineQubit(0) >>> physical_gate = cirq.Z(q).with_tags(cirq.google.PhysicalZTag()) >>> physical_gate cirq.TaggedOperation(cirq.Z(cirq.LineQubit(0)), cirq.google.PhysicalZTag()) >>>...

Admittedly, this is a bit annoying for tags like `PhysicalZTag` that are clearly singletons, so we should see if there's a way to clean that up.

@viathor, currently `with_tags` doesn't do any checking about what kind of objects are used as tags. I seem to recall that we discussed requiring all tags to inherit from some...

I have mixed feelings about this. Sometimes it's nice to redefine variables (I often encounter this when a function accepts an arg with a union type but we then convert...

Seems like we should fix this in circuit diagrams. The str and repr of `cirq.X**-1` do preserve the exponent: ```python In [1]: repr(cirq.X) Out[1]: 'cirq.X' In [2]: repr(cirq.X**-1) Out[2]: '(cirq.X**-1)'...

@mpharrigan, that's a good point about wanting to be concise. But abbreviated names don't lose any information, whereas eliding exponents to show an "equivalent" gate drops info that is useful...

I guess it depends on what "the same" means. They are certainly equivalent in some senses, but not in others, and in particular not in a sense that we care...