Matthew Neeley

Results 62 comments of Matthew Neeley

I have not been able to reproduce the flakiness on either python 3.8.8 or python 3.9.13. How are you invoking pytest? I tried just running the `cirq_google/engine/engine_client_test.py` tests and also...

I think this is a font issue, but we could look at the actual strings and check whether they are aligned to be sure.

A agree that measurements with the same key on different qubits should not be commuted past each other, because that changes the order of results in the measurement record. I...

The sampler error is a known limitation of the current implementation because we never defined how repeated keys should be mapped into the 2D data frame produced by the `sample`...

Insertion ordering is what I mean.

In my view, measurements overlapping is not a problem as long as we maintain the output order. So, for example, if we have a circuit: ```python cirq.Circuit( cirq.Moment(cirq.measure(a, key='m')), cirq.Moment(cirq.measure(b,...

I think we should allow the repeated measurement keys in a moment, since operations are ordered within in a moment there's not ambiguity about which operation will write first into...

I think it'd be fine to allow multiple gates that use a given control bit in the same moment.

The native gate that we calibrate is fsim(pi/4, 0) which in our sign convention corresponds to sqrt(iswap)^{-1}. That's probably why the optimizer was implemented that way. Note, however, that sqrt(iswap)^{-1}...

> But what happens if a user uses a physical Z tag for Rz(pi) pulses to change a sqrt(iswap) to sqrt(iswap)^{-1}. Did they just make the circuit needlessly longer? Yes.