Matthew Neeley

Results 62 comments of Matthew Neeley

I like the idea of a packed representation because it's very natural to get from hardware. A different way to support something like this would be to make `cirq.Result` an...

A somewhat related issue is #3233 which wants to generalize the `Result` type along other axes such as allowing ints (for qudit measurements) or IQ points (for lower-level hardware readout...

Yeah, the serialization code uses lambdas all over the place for extracting and validating gate parameters. We can convert those to be instances of proper classes instead to support pickling...

The async methods on `EngineSampler` currently use the default versions, which fall back to the sync versions and so don't actually do anything asynchronous. Actual support for async calls to...

It is a bit unfortunate that the "all symbols" page shows all of `cirq.Moment`, `cirq.ops.Moment`, and `cirq.ops.moment.Moment`. All of those link to a page showing `cirq.ops.Moment` with the other two...

Columns 5 and 6 of bristlecone are equivalent to foxtail, rotated on its side. We could add a function to map a foxtail circuit into those two columns.

I think the problem occurs also with `use_repetition_ids=True` and whether or not the circuit operation has repetitions. Here's a minimal example: ```python In [1]: q = cirq.q(0) In [2]: circuit...

I think some specific logic for finding measurement operations would be generically useful. For example, in `cirq-google` we have a [`find_measurements`](https://github.com/quantumlib/Cirq/blob/master/cirq-google/cirq_google/api/v2/results.py#L47) function to find measurements in a circuit which does...

I have a PR up to allow symbols for `coupling_mhz`: https://github.com/quantumlib/Cirq/pull/5908. Note that `cirq.Duration` is sweepable if you construct it with a symbol, e.g. `cirq.Duration(nanos=sympy.Symbol('delay_ns'))` but we need to modify...

I'd be ok with removing the checks, since they're easily bypassed by using symbols anyway.