Madelyn Olson

Results 707 comments of Madelyn Olson

The schema validation seems to be failing consistently. It's not reporting which test, but it seems to be because its expecting an integer reply and getting nothing.

Also checked to see if there were any test failures if you force everything to offload, and just the ones we expected: ``` *** [err]: COMMANDLOG - only logs commands...

> The undefined-sanitizer fails in Daily with an unaligned pointer address. I'm just guessing it can be related to this PR. Is it? Seems likely. @xbasel Can you take a...

Thanks for the heads up, I didn't even know we had this in the codebase. We should be able to easily migrate it (or delete it).

We did have a conversation about this at some point, since you can do something like `config get a* *b`, there is really no defined ordering if something matches both....

> Using separate CONFIG GET calls per parameter, which adds round-trip latency. Multi-exec would remove the round-trip latency.

I think I fixed this in https://github.com/valkey-io/valkey/issues/1086, so going to close this one.

> I will let Shiv to check this (I do not know why I can not find his name here ) He needs to either be an collaborator on the...

I think we can fix this by just removing the solo tests from the "completed tests" here: https://github.com/valkey-io/valkey/blob/unstable/tests/test_helper.tcl#L372.

@hpatro If @RayaCoo doesn't respond, would you be able to run them and we can then decide to merge this?