replace centos 7 with almalinux 8, add almalinux 9, centos stream 9, …

[jonathanspw]

trafficstars

…fedora stable/rawhide

Fixes #527

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.13%. Comparing base (a0aebb6) to head (4216e23). Report is 2 commits behind head on unstable.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable     #543      +/-   ##
============================================
- Coverage     70.17%   70.13%   -0.04%     
============================================
  Files           109      109              
  Lines         59904    59905       +1     
============================================
- Hits          42039    42016      -23     
- Misses        17865    17889      +24     

see 14 files with indirect coverage changes

[jonathanspw]

Forked repositories have recurring workflows disabled by default so that shouldn't be needed.

[madolson]

Forked repositories have recurring workflows disabled by default so that shouldn't be needed.

You aren't wrong. I'm not exactly sure of the history of that feature, but we didn't want to change it now because it might have wider implications for folks that pull on their forks. Maybe now is the time to change it.

[madolson]

@jonathanspw Can you fix the DCO check (sign-off on the last three commits). Otherwise I can do it since you were taking my changes.

[jonathanspw]

@jonathanspw Can you fix the DCO check (sign-off on the last three commits). Otherwise I can do it since you were taking my changes.

I used the GH GUI to pull those in. No clue how to do DCO with the GUI. Can you do it?

[madolson]

@jonathanspw I'm sorry, I pushed the wrong branch to your unstable branch and github did not appreciate that (and closed the PR, so I can't update it anymore). Would you mind pushing the content https://github.com/valkey-io/valkey/tree/unstable_jon onto your unstable branch? That should pass all of the checks and will allow my to re-open and merge the PR.

[jonathanspw]

I did a forced push to my branch that included that. Will it let you reopen it now?

[jonathanspw]

Hmm I didn't notice there's a piece in normal CI that does a build on CentOS 7. If you'll give me a minute I can add a commit that will change that as well, unless you'd rather it come in a separate PR.

[madolson]

Hmm I didn't notice there's a piece in normal CI that does a build on CentOS 7. If you'll give me a minute I can add a commit that will change that as well, unless you'd rather it come in a separate PR.

Up to you, I don't have a strong preference. Although I guess it makes sense to do in this PR.

[jonathanspw]

This is ready to merge. Example of a run with the new code in place: https://github.com/jonathanspw/valkey/actions/runs/9228120347/job/25391510821