Ayoub Mrini

> Hey @machine424 I was busy with exams , i will complete this pr today No worries, good luck with your exams!

It'll close this as https://github.com/prometheus/prometheus/pull/14120 was merged. Thanks to you two.

The PR has diverged, with the introduction of regexes, since my initial review. > However, an exact match isn't ideal for every case - sometimes a regex is more convenient...

> The use case for this is not for promtool test, but for testing the PromQL engine itself and verifying that the error messages returned in failure cases are as...

~How about doing this here https://github.com/prometheus/prometheus/blob/eea6ab1cdd24ec69c94ba4b0d165030c89860c8b/scrape/scrape.go#L485-L494~~instead of re-looping again?~ EDIT: that probably not going to work as you're looking for dups across sLoops. ~We may need to do the same...

Are you thinking about any specific metadata? Could you share the use cases?

Maybe we should enforce this using a linter or sth. There is https://github.com/golangci/golangci-lint/pull/3714 and https://github.com/prometheus/prometheus/pull/13220 tried to do that.

Thanks, @tesla59, for your responsiveness and efforts. However, I’m afraid @alexandear re-opened his PR first. He’s the author of the closed PR I linked to, where we discussed the reopening....

> Hmm, I'm not sure that the expanded storage will be effective without additional steps (like described in https://prometheus-operator.dev/docs/operator/storage/#resizing-volumes). Which steps more precisely? Here, we ask the user to expand...

> I tried the steps in a local cluster and the PV didn't expand. I think that `.spec.paused: true` isn't necessary but you still need to delete (with orphan mode)...