openshift-docs
openshift-docs copied to clipboard
openshift
OBSDOCS-547: Remove explicit mention of local persistent storage volu…
Version(s): enterprise-4.12 and later
Issue: OBSDOCS-547
Link to docs preview: Configuring persistent storage
QE review:
- [ ] QE has approved this change.
Additional information:
@eromanova97: This pull request references OBSDOCS-547 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s):
enterprise-4.12and laterIssue: OBSDOCS-547
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Wed Jun 19 06:59:08 - Prow CI generated the docs preview:
https://74645--ocpdocs-pr.netlify.app/ https://74645--ocpdocs-pr.netlify.app/openshift-dedicated/latest/observability/monitoring/configuring-the-monitoring-stack.html https://74645--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-the-monitoring-stack.html https://74645--ocpdocs-pr.netlify.app/openshift-rosa/latest/observability/monitoring/configuring-the-monitoring-stack.html
@eromanova97: This pull request references OBSDOCS-547 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s):
enterprise-4.12and laterIssue: OBSDOCS-547
Link to docs preview: Configuring persistent storage
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@eromanova97: This pull request references OBSDOCS-547 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s):
enterprise-4.12and laterIssue: OBSDOCS-547
Link to docs preview: Configuring persistent storage
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@eromanova97: This pull request references OBSDOCS-547 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
Version(s):
enterprise-4.12and laterIssue: OBSDOCS-547
Link to docs preview: Configuring persistent storage
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
seems we should add one Prerequisites when configure PVC
https://74645--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/monitoring/configuring-the-monitoring-stack.html#configuring-a-persistent-volume-claim_configuring-the-monitoring-stack
* Available StorageClass exists in the cluster.
reason: if there is not StorageClass, we can not create PVC
@eromanova97: This pull request references OBSDOCS-547 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.
In response to this:
Version(s):
enterprise-4.12and laterIssue: OBSDOCS-547
Link to docs preview: Configuring persistent storage
QE review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hmm, I'm not sure that the expanded storage will be effective without additional steps (like described in https://prometheus-operator.dev/docs/operator/storage/#resizing-volumes).
CC: @machine424
Hmm, I'm not sure that the expanded storage will be effective without additional steps (like described in https://prometheus-operator.dev/docs/operator/storage/#resizing-volumes).
Which steps more precisely? Here, we ask the user to expand the PVCs by referring them to the storage doc + we ask them to reflect that in the configmap (to adjust the statefulset). I don't think pausing the Prometheus CR makes sense here. Am I missing sth?
I tried the steps in a local cluster and the PV didn't expand. I think that .spec.paused: true isn't necessary but you still need to delete (with orphan mode) the statefulset. Probably QE should verify this.
I tried the steps in a local cluster and the PV didn't expand. I think that
.spec.paused: trueisn't necessary but you still need to delete (with orphan mode) the statefulset. Probably QE should verify this.
The old procedure required updating the configmap first, which would recreate the statefulset and the pods (as the claim part is immutable). It then asked to resize the PVCs and then delete the statefulset in orphan mode which didn’t make sense as the statefulset was already up-to-date at that stage.
Now, we ask to expand the PVC as explained in https://docs.openshift.com/container-platform/4.15/storage/expanding-persistent-volumes.html#expanding-pvc-filesystem_expanding-persistent-volumes, and then update the configmap. This will recreate the statefulset and the pods.
I gave it a try on a clusterbot and it worked as expected. I think Eliska tried it as well, but let’s see if @juzhao can confirm that.
(I’ve discussed this with multiple persons. I think it’d be great if every procedure in the docs is backed up by an automated test. I’ll create a ticket for that and continue the related discussion there.)
~~Ok I'll try again too...~~ @machine424 sorry for the confusion, I was too much focused on the upstream docs and missed that the PR is more about cleaning up the existing procedure :sweat_smile:
I tried the steps in a local cluster and the PV didn't expand. I think that
.spec.paused: trueisn't necessary but you still need to delete (with orphan mode) the statefulset. Probably QE should verify this.The old procedure required updating the configmap first, which would recreate the statefulset and the pods (as the claim part is immutable). It then asked to resize the PVCs and then delete the statefulset in orphan mode which didn’t make sense as the statefulset was already up-to-date at that stage.
Now, we ask to expand the PVC as explained in https://docs.openshift.com/container-platform/4.15/storage/expanding-persistent-volumes.html#expanding-pvc-filesystem_expanding-persistent-volumes, and then update the configmap. This will recreate the statefulset and the pods.
I gave it a try on a clusterbot and it worked as expected. I think Eliska tried it as well, but let’s see if @juzhao can confirm that.
(I’ve discussed this with multiple persons. I think it’d be great if every procedure in the docs is backed up by an automated test. I’ll create a ticket for that and continue the related discussion there.)
should edit the PVC size first, then wait for it's resized before resize
$ oc -n openshift-monitoring get pvc
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS VOLUMEATTRIBUTESCLASS AGE
alertmanager-alertmanager-main-0 Bound pvc-845a2fe8-8275-4698-860a-b3789572422d 4Gi RWO managed-csi <unset> 18m
alertmanager-alertmanager-main-1 Bound pvc-37ea1d39-fbb0-4c3e-950e-d9917b642e02 4Gi RWO managed-csi <unset> 18m
after resize
$ oc -n openshift-monitoring get pvc
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS VOLUMEATTRIBUTESCLASS AGE
alertmanager-alertmanager-main-0 Bound pvc-845a2fe8-8275-4698-860a-b3789572422d 10Gi RWO managed-csi <unset> 19m
alertmanager-alertmanager-main-1 Bound pvc-37ea1d39-fbb0-4c3e-950e-d9917b642e02 10Gi RWO managed-csi <unset> 19m
then edit cluster-monitoring-config configmap
A few outstanding questions and nits - overall, great work! /label peer-review-done /remove-label peer-review-in-progress
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@eromanova97: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@eromanova97: This pull request references OBSDOCS-547 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.
In response to this:
Version(s):
enterprise-4.12and laterIssue: OBSDOCS-547
Link to docs preview: Configuring persistent storage
QE review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
