Mat Kelly

Results 844 comments of Mat Kelly

If we are looking for Windows-based CI, why even use a container in this scenario?

AppVeyor supports Windows-based CI testing and is free for OSS projects. I have registered the ipwb repo with this service so we can test this.

Add `ipwb/samples/indexes/froggie_badHeaderHash.cdxj` in 72be79bb624a904ba95fdb46f5ed97b38ff03640 as an example where the HTTP header hash does not resolve, preventing the payload from being displayed. A follow-up might be to fabricate a header with...

Retaining the most recent index in the config, as we did before but I am unsure we still do, would make this process have a failsafe in the case where...

Ah, ok, so the objective is to prevent indexes in `/tmp/` from automatically being purged. I was thinking that you wanted the admin to have the ability to easily restart...

While we already have the path (e.g., `/tmp/717386A20Z3G.cdxj`) to the updated index file displayed in the replay homepage admin interface, we do not yet link it. While this could be...

I agree to separate the admin options and user options. Perhaps an admin view in the banner to access those options? Having to go to a separate interface from what...

I'm guessing one does not exist given the query for "cdxj" in pypi directs the user to ipwb.

Or rather, the functionality of pywb could be reused since, y'know, we are already using that very module.

On a second look, it does not appear that pywb has any sort of CDXJ validation. There is a `parse_cdxj()` that might throw an exception we can catch.