Mat Kelly

Results 844 comments of Mat Kelly

Above revised somewhat: ```py import asyncio import time import json async def consumer(queue): while True: line = await queue.get() doWork(line) queue.task_done() async def producer(): N_TASKS = 10 loop = asyncio.get_event_loop()...

A simpler example using the built-in `multiprocessing` looks to be a little faster than the linear synchronous approach: ```py from multiprocessing import Pool def multiprocess(): pool = Pool(4) with open('sample.cdxj',...

Pending a test passing and probably some better documentation, but I would appreciate your feedback on the diff here, @ibnesayeed.

@ikreymer This initial implementation is base support for WACZ. We are hoping to do more with the format in the future beyond treating it as a container for WARCs. Reusing...

@ibnesayeed I would like your re-review here, as I added some logic to retain the temp paths and remove them as required so as to not have side effects. Inferring...

Another caveat is whether subdirectories beyond /archive are legal for WARC storage in WACZ. This would cause any removal of the structure in WACZ not being retained in the on-disk...

Looks like base pip does not support the pipfile format. As far as I am aware, pipenv is not distributed with python like pip, so I think we ought to...

> it is a development environment setup related matter Can we still recommend users install ipwb using `pip install ipwb` if we use a pipfile in lieu of various requirements...

@ibnesayeed So, a user will still be able to install using pip? As I understand from the documentation, eventual support for using pipfiles from pip is planned.

Ok, let's proceed on the efforts to use a pipfile then to resolve the variable, multiple requirements files.