Mat Kelly

Results 844 comments of Mat Kelly

CDXJ TimeMap support added in e4a9ee9e5a27feb0158c3ce735e5a0555835b8c9. Tests should still be written for this, as it will likely be a big ding in coverage given the new function.

If the key is removed from a CDXJ, a user will need another way to decrypt the contents. This provides the mechanism for the scenario where one receives a CDXJ...

You are right about it being weird that the request for a file is in the request handler though. This is due for some refactoring.

> as long as it is supplied at the time of server invocation At some point we want the indexed contents to be more dynamic at runtime. However, I agree...

> they can be offloaded to a separate key index. I had yet to consider this but it would be interesting to have it as an option as a method...

I made some adjustments in cc43d7c (issue-447 branch) to consider encryption as a JSON object instead of separate encryption attributes (e.g., `encryption_key`) as separate attributes on the main object. Also,...

Also, no right-facing triangle on Options and Details.

The content in the `` tag outside of the nested `` tag should not be displayed by default. This looks to be an IE bug: ![details](https://user-images.githubusercontent.com/2514780/33773069-bcf7f7b6-dc04-11e7-8c5e-f72dc8248132.png) However, the triangle shows...

Verified as not supported by IE: https://caniuse.com/#feat=details

[This](https://mathiasbynens.be/notes/html5-details-jquery) appears to be the best polyfill to add for the time being with graceful fallback to the native `` implementation when supported. ...but I don't plan on adding jQuery...