Mat Kelly

Results 550 comments of Mat Kelly

One of the barriers to moving this function is that it is dependent on the IPFS HTTP Client, which is `global`. This likely hints at a larger underlying problem. Does...

The global was removed in #640 in favor of a function call to util to obtain the client. The same goes with the `.cat()`s in replay.

I am able to replicate a very long delay on a Windows 10 VM. Using latest master (4fca791): * the first test-backends fails * all other test-backends pass * all...

Dropping to the debugger on the first failure might be informative, e.g. (view raw), Output > pytest -x --pdb ================================================= test session starts ================================================= platform win32 -- Python 3.8.3, pytest-5.4.3,...

`get_web_archive_index()` handles an index define by 1: IPFS Multihash address, 2: web URI, 3. local file/path but does not interpret the string `!context ["http://tools.ietf.org/html/rfc7089"]`. Further testing is needed to determine...

It might help, @ibnesayeed, but I am curious as to why it is considered a hash on macOS but not Windows. This might also point to a bug in py-ipfs-http-client....

@ibnesayeed What I tried is documented above. More to come.

Related: https://github.com/Siderus/Orion/issues/133 and https://github.com/oduwsdl/ipwb/issues/388

Any further thoughts since October about a better name, @ibnesayeed ?

@ibnesayeed Those seem fitting albeit not nearly as "user-friendly" as "locator", which might be a moot point if the intention of ipwb CDXJs is to be machine readable. Any other...