m4b
So iiuc we just need to add the magic number to our magic numbers ? Or is something else involved ?
@jayvdb sure if you want to submit a PR making error messaging better or somehow returning more info feel free! If no I’m going to close this issue though since...
I don't think there's a reason, other than simple omission :) A PR adding it would be great and much appreciated!
@philipc sorry, it wasn't clear; were you indicating this was a bug in us, or in clients using the note iterator, for when it loops infinitely? I'm inclined to believe...
Auditing sounds good to me; will have to evaluate pros and cons of switching as you mention. I’d also like to fix goblin parse return to be more ergonomic. But...
I don’t think log has any dependencies unless I’m mistaken ?
It looks like it has cfg-if as a dep and two optional others, which is quite annoying. I don’t remember when they were added (or why): Dependencies cfg-if ^0.1.2 serde...
Is the serde or eval dep getting turned on for you somehow?
I guess I don’t understand why 1. getting rid of log would help manage dependencies since there are others, and 2. I’m not sure why dependencies are an issue in...
So scroll itself will never have an external dep, because I’m the owner and I say so :) (I guess never say never but I don’t see it happening, maybe...