m4b
m4b
Actually it looks like log already is optional though I don’t know to what extent at the moment it disables functionality. I would have to check :)
Looks like the functionality is half implemented: https://github.com/m4b/goblin/search?q=log&type= @lygstate if you want you could open up a PR making log fully optional. Might be better to create a macro like...
So with the new `alloc` feature I think just adding derive annotation will work as expected and won't cause any problems in `no_std` environments, would you agree @philipc ?
Ok I think we should get the error story figured out. I'm leaning towards sticking with current error system, not pulling on another dep, as it's compatible with downstream users...
Something like this sounds good to me. Would you @Evian-Zhang (or anyone else) be interested in collecting a list of pub functions that are candidates for pub(crate)? Please note: all...
what is the `.debug` file? is it additional dwarf debug information? Who produced it? Just wondering why the PT_DYNAMIC is incorrect; that's usually pretty bad. We could potentially make these...
Many parts of the parser rely on the binary giving lengths to various variable length entities; I guess the best we can do here is to clamp the maximum size...
@shnatsel do you want to make a PR :)
These are all good questions, and I'm not sure what the best answer is; I think we've tried to be as robust as possible in the past, but it starts...
Well you don't have to fs::read; `goblin::Object::parse` takes a `&[u8]`; so e.g., if you're on linux you could probably memmap the binary in `/proc/` or whatever, and it might share...