m4b comments

Results 341 comments of

m4b

elf.parse: resolve overflow issue in hash sections

Hmmm looks like macos CI is failing (for likely unrelated reasons ??)

elf.parse: resolve overflow issue in hash sections

it looks like `/Library/Developer/CommandLineTools/usr/bin/dyldinfo` doesn't exist anymore, so that's the failure

elf.parse: resolve overflow issue in hash sections

Oh you sweet, sweet cherub @willglynn , swooping in and saving the day; @quake this is annoying, but would you mind changing https://github.com/m4b/goblin/blob/e94ca6b81b3b3a87ed5efc94493b790fd1085355/tests/compare_dyldinfos.rs#L4 to `xcrun dyldinfo` ?

elf.parse: resolve overflow issue in hash sections

actually it may be more complicated, maybe a separate PR is better

elf.parse: resolve overflow issue in hash sections

Oh wow you're right; fwiw, it should probably be updated to not hard code anyway, since it can fail on other machines, something perhaps like: ```diff diff --git a/tests/compare_dyldinfos.rs b/tests/compare_dyldinfos.rs...

elf.parse: resolve overflow issue in hash sections

@lzutao perhaps you have some thoughts on behavior of overflow wrapping, you did the work on the gnu hash rewrite

elf.parse: resolve overflow issue in hash sections

@quake are you still interested in getting this merged? let me know whenever you have a chance, just triaging old PRs here, thanks!

`vm_range` is lossy on 32-bit platforms reading 64-bit objects

Yea :/ so I think this was originally used to allow indexing into actually mapped memory. So I'm not exactly sure what a 32-bit program running this would do with...

`vm_range` is lossy on 32-bit platforms reading 64-bit objects

I’d be interested in merging a fix like this to roll up one other breaking change in 0.5 release

Missing tag for 0.4.3?

Sorry I missed this, will add a tag