goblin icon indicating copy to clipboard operation
goblin copied to clipboard

Don't return err when parsemode is permissive

Open Kharosx0 opened this issue 4 months ago • 6 comments

Ignore more errors and continue parsing when ParseMode is Permissive (e.g. an erroneous resource directory should not prevent parsing of the PE when ParseMode is Permissive).

Kharosx0 avatar Aug 19 '25 02:08 Kharosx0

Probably a duplicate of #479?

kkent030315 avatar Aug 19 '25 09:08 kkent030315

Not exactly a duplicate, I’d say this is complementary to #479. In my pull request, I introduced granular permissive handling within individual parsers, whereas this provides a higher-level safety net for cases that remain uncovered

chf0x avatar Aug 19 '25 13:08 chf0x

needs rustfmt

m4b avatar Aug 25 '25 01:08 m4b

needs rustfmt

Done

Kharosx0 avatar Sep 17 '25 21:09 Kharosx0

@Kharosx0 this needs a rebase now; after that let's re-review now that permissive stuff has landed. You may be able to use the new trait to help with this, not sure.

m4b avatar Sep 21 '25 18:09 m4b

@Kharosx0 are you still interested in this? If so, can you checkout the latest goblin, and see if the new parsemode permissive changes are working like your PR, as they may already be implementing this, thanks!

m4b avatar Oct 20 '25 04:10 m4b